representing_work_order

Template:— representing_work_order (rep_wrk_ord)

Date: 2010/03/14 16:33:25
Revision: 1.31

Cover Contents Description Model diags.Input params.Ref. params.Instantiation path Instance diags.Characterizations Issues

Issue raised against: representing_work_order

GENERAL issues

Issue: RBN-1 by Rob Bodington (07-01-02) minor_technical issue
Resolution: Accept. Status: closed

A number of the input parameters should be defined types, not integers. The input parameters that are enumerations should have the enumeration specified.

Comment: (Rob Bodington 07-01-02)
Corrected.

Issue: RBN-2 by Rob Bodington (07-03-27) minor_technical issue
Resolution: Accept. Status: closed

In this template path the following can be read: /assigning_activity(role_class_name='', role_ecl_id='', assigned_activity='', items=@input)/ Should it be at least: /assigning_activity(role_class_name='', role_ecl_id='', assigned_activity=^dir_act, items=@input)/ What about values for role_class_name and role_ecl_id? Are they intented to be empty strings? Also the following are missing in the path: ^work_order.name = /IGNORE ^work_order.description = /IGNORE (eventually) ^dir_act.id = /IGNORE ^dir_act.name = /IGNORE ^dir_act.description = /IGNORE (eventually)

Comment: (Rob Bodington 07-04-13)
Changed to: /assigning_activity(role_class_name='Activity_input', role_ecl_id='urn:plcs:rdl:std', assigned_activity=^dir_act, items=@input)/ and added the ref parameters

Issue: TRO-1 by Trisha Rollo (07-07-16) minor_technical issue
Resolution: Accept. Status: closed

Short name does not conform to validation rules

Comment: (Trisha Rollo 07-07-16)
Changed

Issue: RBN-3 by Rob Bodington (07-07-06) minor_technical issue
Resolution: Accept. Status: closed

The model diagram in Figure 1 should make it clear what is instantiated by the template and was is there for information. The characterizations should be shown in a characterization diagram.

Comment: (Rob Bodington 07-07-18)
Corrected

Issue: TRO-2 by Trisha Rollo (07.09.12) minor_technical issue
Resolution: Accept. Status: closed

The description refers to work_request rather than work _order

Comment: (Rob Bodington 07-11-04)
Corrected

Issue: RBN-4 by Rob Bodington (07-11-15) minor_technical issue
Resolution: Accept. Status: closed

The default classification of the parameter id_class_name is given as "Work_request_identification_code" it should be Work_order_identification_code

Comment: (Rob Bodington 07-11-29)
Corrected

Issue: RBN-5 by Rob Bodington (07-11-29) minor_technical issue
Resolution: Accept. Status: closed

The intro starts "This a description of a work request" -- it is a work order

Comment: (Rob Bodington 07-11-29)
Corrected

Issue: RBN-6 by Rob Bodington (07-11-04) minor_technical issue
Resolution: Accept. Status: closed

There needs to be a reference parameter referencing the Applied_activity_assignment so that effectivities and conditions can be applied to it.

Comment: (Rob Bodington 07-11-06)
Updated

Issue: DNV-79 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: Shall both entities Work_order and Directed_activity be assigned Issuing_person/organization? It seems that Issuing person is only needed at Work_order.

Comment: (Rob Bodington 07-11-19)
It may be teh case that one organization raises the work order on another organization who then raises the directed_activity. I have removed the mandatory assignment from the express g diagram

Issue: DNV-80 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 07-11-06)
Spelling errors in XML comments don't count ;-)

Issue: DNV-81 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 07-11-06)
Raised and addressed as infrastructure issue: http://www.eurostep.fi/bugs/show_bug.cgi?id=1110

Issue: DNV-82 by Fredrik Lied Larsen, DNV (2007-11-30) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 20 Status: in_model_review

Comment: (Rob Bodington 07-11-06)
corrected

Issue: DNV-83 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 24 The template description is wrong. It seems to be reused from representing_work_request.

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-84 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 40/41 The EXPRESS-G diagram does not include attributes for entity Directed_activity. These should come from the super type Activity. Attributes for Work_order are not populated with '/IGNORE'.

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-85 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 29 Parameters chosen_method and in_response_to is not explicitly stated in the EXPRESS-G diagram.

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-86 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 35 Template parameters for assigning_activity is not within the template or in brackets.

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: DNV-87 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: Parameters chosen_method and in_response_to are optional in the input parameter section but not in EXPRESS-G diagram or the graphical representation section.

Comment: (Rob Bodington 07-11-19)
in_response_to is an aggregate of 0..? hence optional chosen_method is no longer optional

Issue: DNV-88 by Fredrik Lied Larsen, DNV (2007-11-30) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 48 Reference parameter for Directed_activity is shown below the abbreviated representation of the template.

Comment: (Rob Bodington 07-11-06)
That is so that the connection of the assing_org etc can be shown.

Issue: DNV-89 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 53 Parameter id_class_name has wrong entrance class, should not be Work_request_identification_code.

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-90 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 70 Some templates in the example EXPRESS instance diagram are optional in the template representing_work_order. These should not be marked with grey.

Comment: (Rob Bodington 07-11-06)
Why not?

Comment: (Rob Bodington 07-11-19)
They are marked in grey

Issue: DNV-91 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 71 Template assigning_reference_data is assigned to both Work_order and Directed_activity.

Comment: (Rob Bodington 07-11-19)
Yes ...

Issue: DNV-92 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 72 org_id='BikeRent Limited' is changed in the instance diagram to org_id='BikeRepair Limited'. Also for act_org_id='BikeRent Limited'.

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-93 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 73 All have URN='urn:plcs:rdl:std'

Comment: (Rob Bodington 07-11-06)
Which is correct

Issue: DNV-94 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 76 Templates that are optional in the model diagram are not represented by dashed border line.

Comment: (Rob Bodington 07-11-19)
They are shaded in grey ....

Issue: DNV-95 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 77 See issue #72

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: DNV-96 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 80 Reference from Work_order named in_response_to does not state the reference_parameter within representing_work_request it relates to.

Comment: (Rob Bodington 08-01-16)
Added

Issue: DNV-97 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: The example includes a part named 'Mandatory characterization', what is the meaning of this? Is it the issuing organization from the model diagram?

Comment: (Rob Bodington 07-11-19)
Yes

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: DNV-98 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 07-11-06)
Corrected

Issue: DNV-99 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 88 Should be a uniqueness constraint that determines the minimum population of the template

Comment: (Rob Bodington 07-11-19)
Agree - unique constraint added

Issue: DNV-100 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 90 See issue: #85, #86, #84

Comment: (Rob Bodington 08-01-16)
There is an instantiated template diagram

Issue: DNV-101 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 90 No graphical representation of the template so all checlist items between #42 and #49 are missing.

Comment: (Rob Bodington 08-01-17)
Figure 5 shows the characterizations

Issue: DNV-102 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 90 No example of characterizations. So all checlist items between #67 and #86 are missing.

Issue: DNV-103 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 91 Characterization 'Assigning person or organization' is mandatory; therefore it is not a characterization.

Comment: (Rob Bodington 08-01-16)
It is a characterization.

Issue: DNV-104 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 91 Characerization 'Assigning dates and times' is in conflict with the model diagram. There is already a template that sets issuing time for the work_order.

Comment: (Rob Bodington 07-11-19)
reworded characterization

Issue: DNV-105 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 49 Additional parameters are shown within the template representation. The parameters are 'state_class_name', 'state_ecl_id', 'purpose' and 'purp_ecl_id'

Comment: (Rob Bodington 07-11-19)
I don't see these ....

Issue: DNV-106 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 07-11-19)
The descriptions of the dates parameters have been reworded, and a class: Work_order_issue_date introduced. act_id has been changed to make it clearer what is being identified.

Issue: DNV-107 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 52 'Sense' has type=ENUMERATION.

Comment: (Rob Bodington 07-11-06)
Enumeration is acceptable - the checklist needs to be corrected

Issue: DNV-108 by Fredrik Lied Larsen, DNV (2007-11-30) minor_technical issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\checklists_12_07\all_template_issues.xls Template: representing_work_order Check list clause: 56 Act_org_id_ecl_id, act_id_ecl_id, date_ecl_id, org_id_ecl_id and id_ecl_id does not reference 'urn:plcs:rdl:std' as default.

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: DNV-109 by Fredrik Lied Larsen, DNV (2007-11-30) major_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 07-11-19)
Updated

Issue: LOGSA-RI-1 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: All figures missing sequential numbers

Comment: (Rob Bodington 08-01-17)
They do have sequential numbers

Issue: LOGSA-RI-2 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: No reviewers identified

Comment: (Rob Bodington 08-01-17)
Added

Issue: LOGSA-RI-3 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: In model review

Comment: (Rob Bodington 08-01-17)
Changed

Issue: LOGSA-RI-4 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: No purpose stated

Comment: (Rob Bodington 08-01-17)
There is a description

Issue: LOGSA-RI-5 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: No restrictions

Comment: (Rob Bodington 08-01-17)
Restrictions are optional - a number of uniqueness constraints have been added

Issue: LOGSA-RI-6 by , LOGSA (2007-10-25) editorial issue
Resolution: Accept. Status: closed

Issue file: D:\users\rbn\projects\010937_DNV_dexlib\docs\review\LOGSA Template Reviews\template_issues.xls Template: representing_work_order Check list clause: Parameters are in parentheses not brackets

Comment: (Rob Bodington 08-01-17)
The checklist needs to be clearer

Issue: LOGSA-RI-7 by , LOGSA (2007-10-25) minor_technical issue
Resolution: Accept. Status: closed

Comment: (Rob Bodington 08-01-17)
Updated

Issue: RBN-7 by Rob Bodington (08-01-22) minor_technical issue
Resolution: Accept. Status: closed

The assigning_approval template now requires person_organization as input.

Comment: (Rob Bodington 08-01-22)
Added input parameter, updated path and main express-g diagram - still need to update examples and other express-g diagram

Comment: (Rob Bodington 08-02-15)
Updated examples and other express-g diagram

Issue: RBN-8 by Rob Bodington (08-03-10) minor_technical issue
Resolution: Accept. Status: closed

The reference data "Approval_status" has the same name as the entity Approval_status Rename the reference data to "Status_of_approval"

Comment: (Rob Bodington 08-03-10)
Corrected