Template:— representing_numeric_property (rep_num) Date: 2008/01/21 08:52:14
Revision: 1.20
CoverContentsDescriptionModel diags.Input params.Ref. params.Instantiation pathInstance diags.CharacterizationsIssues

Issue raised against: representing_numeric_property

GENERAL issues

Closed issue Issue: RBN-1 by Rob Bodington (07-01-03) minor_technical issue
Resolution: Accept. Status: closed

Figure 1 and the instantiation path show a reference parameter ^item. This has not be declared.
Comment: (Rob Bodington 07-01-03)
Corrected

Closed issue Issue: PBM-1 by Peter Bergström (2007-02-16) minor_technical issue
Resolution: Accept. Status: closed

The necessity of chosing a datatype for the input parameter 'value' is not made clear in the parameter definition. It appears that value can be "5" or similar, when in fact the datatype must be given as well, e.g. "ANY_NUMBER_VALUE(5)".
Comment: (Peter Bergström 2007-02-16)
Fixed by editing the parameter description. I also harmonized the description of parameter si_unit with other templates.

Closed issue Issue: TRO-1 by Trisha Rollo (2007-06-27) minor_technical issue
Resolution: Accept. Status: closed

short name not to validation rules
Comment: (Trisha Rollo 2007-06-27)
amended

Closed issue Issue: TRO-2 by Trisha Rollo (2007-06-27) minor_technical issue
Resolution: Accept. Status: closed

names on figures do not match template name
Comment: (Trisha Rollo 2007-06-27)
amended

Closed issue Issue: RBN-2 by Rob Bodington (07-08-09) minor_technical issue
Resolution: Accept. Status: closed

There should be a uniqueness constraint on the Numerical_representation_context Numerical_representation_context should be unique with the context (context, context_ecl_id)
Comment: (Rob Bodington 08-01-13)
The Numerical_representation_context needs to be referenced by a reference parameter hence added
Comment: (Rob Bodington 08-01-13)
Corrected

Closed issue Issue: GYL-1 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 3: There is a set of png-files under the image folder which are not used by this template.
Comment: (Mike Ward 2008-01-17)
Unused png files deleted.

Closed issue Issue: GYL-2 by Leif Gyllstrom (2007-12-12) editorial issue
Resolution: Accept. Status: closed

Review issue. Review item 13: Figures under the section Instance diagrams are hard to read. Enlarge. Also, some attribute names are hidden behind entity instances.
Comment: (Mike Ward 2008-01-17)
All diagrams redrawn and these problems addressed.

Closed issue Issue: GYL-3 by Leif Gyllstrom (2007-12-12) editorial issue
Resolution: Accept. Status: closed

Review issue. Review item 14: Characterization section does not fully comply with this. E.g. references to Person, Organization etc.
Comment: (Mike Ward 2008-01-17)
All entity names (cf references ot real world objects) are hyperlinked.

Closed issue Issue: GYL-4 by Leif Gyllstrom (2007-12-12) major_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 26: The Numerical_ representation_context entity has two attributes which are not shown in the EXPRESS-G diagram (accuracies and units). Those should be added, with a comment that they are not being instantiated by this template.
Comment: (Mike Ward 2008-01-17)
Accuracies and units attributes added to expg diagram.

Closed issue Issue: GYL-5 by Leif Gyllstrom (2007-12-12) major_technical issue
Resolution: Accept. Status: closed

Review issue. Review items 26, 41: Entity supertypes are not shown in the EXPRESS-G diagram. The Express model is not consistent with AP239 ARM.
Comment: (Mike Ward 2008-01-18)
Diagram redrawn with supertypes.

Closed issue Issue: GYL-6 by Leif Gyllstrom (2007-12-12) editorial issue
Resolution: Accept. Status: closed

Review issue. Review item 30: No expicit relation between input parameters and template attributes (e.g. arrows).
Comment: (Mike Ward 2008-01-17)
All diagrams redrawn and arrows added.

Closed issue Issue: GYL-7 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 51: Input parameter si_unit. Do we need to bring in explanations on Part 21 and Part 28 representations in every template that just passes on the values to another template.
Comment: (Mike Ward 2008-01-17)
There is now a note explaining the Part 21 and Part 28 representation issue.

Closed issue Issue: GYL-8 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 53: Input parameter context. Should we be able to reuse representation contexts that are being defined as subclasses of the class Representation_context?
Comment: (Mike Ward 2008-01-17)
For each use of an RDL class there is clause which says: "The following classes and their sub-classes can be used:".

Closed issue Issue: GYL-9 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 62: An Entity is assigned to the input parameter items of the template assigning_reference_data. Entity is not in the list of allowed assignments.
Comment: (Mike Ward 2008-01-17)
"Items" is not a reference parameter. All input parameters are correctly assigned.

Closed issue Issue: GYL-10 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 67: Textual description of template @66 does not show all input parameters.
Comment: (Mike Ward 2008-01-17)
"Items" is not a reference parameter. All input parameters are correctly assigned.

Closed issue Issue: GYL-11 by Leif Gyllstrom (2007-12-12) editorial issue
Resolution: Accept. Status: closed

Review issue. Review item 70: Not done for any of the graphical template instantiation diagrams.
Comment: (Mike Ward 2008-01-17)
All diagrams redrawn with grey boxes around entities that are not instantiated by the template.

Closed issue Issue: GYL-12 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 71: Additional characterization is provided in the Express instance diagram.
Comment: (Mike Ward 2008-01-17)
No additional characterization is shown in the main Express instance diagrams. Additional instance diagrams are used to illustrate characterization, but while this is not required, it does not conflict with the guidelines.

Closed issue Issue: GYL-13 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 88: See open issue RBN-2.
Comment: (Mike Ward 2008-01-17)
All issues now addressed.

Closed issue Issue: GYL-14 by Leif Gyllstrom (2007-12-12) major_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 90: The EXPRESS-G diagram does not comply with AP239 ARM. It does not show superclasses and inheritance, but is an EXPRESS-G version of an instance diagram.
Comment: (Mike Ward 2008-01-18)
All inherited attributes shown in diagram. No requirement for supertype entities to be shown.

Closed issue Issue: GYL-15 by Leif Gyllstrom (2007-12-12) minor_technical issue
Resolution: Accept. Status: closed

Review issue. Review item 91: Characterizations should comply with Peter Bergstom's notes in Properties in DEXlib meeting notes 2007-08-13.doc.
Comment: (Mike Ward 2008-01-18)
All characterizations appear to be correct.

Closed issue Issue: GYL-16 by Leif Gyllstrom (2007-12-12) editorial issue
Resolution: Accept. Status: closed

Review issue. Review item 91: Each caracterization ends with a statement "instead." Question is , instead of what ?
Comment: (Mike Ward 2008-01-18)
Characterization statements clarified.