product_property_w_tolerances

Template:— product_property_w_tolerances (prod_prp_tol)

Date: 2010/03/25 12:02:57
Revision: 1.23

Cover Contents Description Model diags.Input params.Ref. params.Instantiation path Instance diags.Characterizations Issues

Issue raised against: product_property_w_tolerances

GENERAL issues

Issue: PBM-1 by Peter Bergström (2007-02-16) minor_technical issue
Resolution: Accept. Status: closed

The necessity of chosing a datatype for the input parameter 'value' is not made clear in the parameter definition. It appears that value can be "5" or similar, when in fact the datatype must be given as well, e.g. "ANY_NUMBER_VALUE(5)".

Comment: (Peter Bergström 2007-02-16)
Fixed by editing the parameter description. I also harmonized the description of parameter si_unit with other templates.

Issue: GYL-1 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 6: Most of the master file attributes are missing

Comment: (Ann Meads 2007-12-14)
Added master attribute values.

Issue: GYL-2 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 7: Some of the characterization editable files are missing (three to be exact)

Comment: (Ann Meads 2007-12-14)
Added files.

Issue: GYL-3 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 13: Reference parameters in model diagrams should be enlarged for better readability.

Comment: (Ann Meads 2007-12-14)
Increased to 9pt.

Issue: GYL-4 by Leif Gyllstrom (07-12-09) editorial issue
Resolution: Accept. Status: closed

Review issue, review item 13: Figures under the Instance diagrams section needs to be enlarged. These are hard to read.

Comment: (Ann Meads 2007-12-14)
Enlarged.

Issue: GYL-5 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 14: References within the characterization section does not comply with this rule. E.g. characterization assigning person or organization where person and organization is stated without hyperlinks to the respective entity.

Comment: (Ann Meads 2007-12-14)
Added hyperlinks for organization, person and date time assignment.

Issue: GYL-6 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 30: No explicit relation between input attributes and constructs in the diagram (e.g. by arrows).

Comment: (Ann Meads 2007-12-14)
Added arrows.

Issue: GYL-7 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 51: Input parameter 'si_unit'. Do we need to bring in explanations on Part 21 and Part 28 representations ?

Comment: (Ann Meads 2007-12-17)
The view was that we should include this explanation. Unit is the only place in the model where this occurs.

Issue: GYL-8 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 51: Input parameter 'context'. Should we be able to reuse representation contexts that are being defined as subclasses of the class 'Representation_context' ?

Comment: (Ann Meads 2008-01-31)
Agreed. Changed numerical_representation_context to representation_context.

Issue: GYL-9 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Review issue, review item 48: Is it right to put a negative number as lower_limit ?

Comment: (Ann Meads 08-01-31)
A value_with_tolerances specifies a range of values by specifying a single nominal value and two tolerances that are offsets from the single value. The range is defined to be the closed interval [item value + lower limit, item value + upper limit]. Therefore, the lower limit should always be negative. As a consequence, other w_tolerances should be consistent and an issue raised.

Issue: GYL-10 by Leif Gyllstrom (07-12-09) editorial issue
Resolution: Accept. Status: closed

Review issue, review item 82: The value of 'value' shall include any_number_value()

Comment: (Ann Meads 2007-12-14)
Edited GI to display any_number_value().

Issue: GYL-11 by Leif Gyllstrom (07-12-09) editorial issue
Resolution: Accept. Status: closed

Review issue, review item 90: Reference to template product_property_w_tolerances are sometimes made within '', sometimes not. Should be consistent.

Comment: (Ann Meads 2007-12-14)
Made overall characterisation diagram same as others i.e. template view.

Issue: GYL-12 by Leif Gyllstrom (07-12-09) minor_technical issue
Resolution: Accept. Status: closed

Characterization should comply with Peter Bergstrom paper on property characterization defined during the DEX3 harmonization workshops. See uploaded document : 'Properties in DEXlib meeting notes 2007-08-13.doc'.

Comment: (Ann Meads 2008-01-31)
Added general advice in a boxed note in the description section. The approach was decided to be multiple representations for one property for cases such as estimated and measured weight. General advice to separate the qualification from the name of the property has also been given. The qualification/determination classification was moved from property_representation to property_value_representation in line with the properties document. The issue raised in the capability for product_property_range applies.

Issue: GYL-13 by Leif Gyllstrom (08-01-24) minor_technical issue
Resolution: Accept. Status: closed

Declaration of input parameter value should be changed from:
< param_in name="value" type="SELECT" select_type="measure_value">
<description>
The value of the property.
The datatype must also be indicated in this parameter, e.g.
"ANY_NUMBER_VALUE(5)".
</description>
</param_in>
to something like:
<param_in name="value" type="TYPE" defined_type="any_number_value">
<description>
The value of the property. The datatype is always 'any_number_value'
and should not be registered together with the value, i.e. enter the
value as a number, without datatype.
</description>
</param_in>

Comment: (Ann Meads 2008-01-31)
Changed as suggested.

Issue: PBM-2 by Peter Bergström (2009-03-23) editorial issue
Resolution: Accept. Status: closed

Parameter @unit is incorrectly described, it is not a class of a unit, it is a name of a unit. The description of parameter @unit_ecl_id needs also changing.
A default value for @context would also be good, suggest Numerical_representation_context.

Comment: (Peter Bergström 2009-03-23)
Fixed both issues.