assigning_observation

Template:— assigning_observation (asg_obs)

Date: 2008/02/21 16:29:21
Revision: 1.19

Cover Contents Description Model diags.Input params.Ref. params.Instantiation path Instance diags.Characterizations Issues

Issue raised against: assigning_observation

GENERAL issues

Issue: RBN-1 by Rob Bodington (07-03-29) minor_technical issue
Resolution: Accept. Status: closed

In this template definition the following parameter are defined: applies_to(Type= 'SELECT (observation_content_item)' ) related_records(Type= 'SELECT (observation_content_item)' ) In the path we have: Observation.applies_to -> @applies_to Observation.related_records -> @related_records But in the latest version of the AP239 schema (in DEXlib) we have: ENTITY Observation; [...] applies_to : SET OF Observation_item; [...] related_records : SET OF Observation_item; END_ENTITY; ENTITY Observation_item; access_comment : STRING; item_identifier : STRING; item_type : STRING; END_ENTITY; TYPE observation_content_item = SELECT (Product, Product_version, Activity, State); END_TYPE; Either the input parameters should be defined as: applies_to(Type= 'SELECT (observation_item)' ) related_records(Type= 'SELECT (observation_item)' ) or something is wrong in the schema. ------- Additional Comment #1 From Patrick Houbaux 2007-03-28 11:54 ------- ot they could be defined as: applies_to(Type= 'SELECT (observation_item_selected)' ) related_records(Type= 'SELECT (observation_item_selected)' ) since: ENTITY Observation_item_selected SUBTYPE OF (Observation_item); contents: observation_content_item; END_ENTITY; ------- Additional Comment #2 From Patrick Houbaux 2007-03-28 13:10 ------- Actually (after a deeper analysis by looking at the model diagram which is also wrong - the contents attribute of entity Observation_item_selected is not a SET - ) the types of these parameters are correct but 1) the path appears not to be correct 2) this template needs an additional reference parameter of type Observation_item_selected named ^observation_item_related_records 3) the existing reference parameter ^observation_item need to be renamed to ^observation_item_applies_to Then the path would be: Observation -- Mark the Identification_assignment entity as -- referable when this template is used by binding it to the reference -- parameter id_assgn %^observation = Observation% Observation.id = '/IGNORE' Observation.name = '/IGNORE' Observation.description = '/IGNORE' -- Modif phx Observation.applies_to -> @applies_to -- Modif phx Observation.related_records -> @related_records Observation.observed_during -> @observed_during Observation.observed_by -> @observed_by Observation.in_context -> @in_context -- Modif phx Observation_item_selected %^observation_item_applies_to = Observation_item_selected% Observation.applies_to -> ^observation_item_applies_to ^observation_item_applies_to.contents -> @applies_to ^observation_item_applies_to.item_identifier = '/IGNORE' ^observation_item_applies_to.item_type = '/IGNORE' ^observation_item_applies_to.access_comment = '/IGNORE' Observation_item_selected %^observation_item_related_records = Observation_item_selected% Observation.applies_to -> ^observation_item_related_records ^observation_item_related_records.contents -> @related_records ^observation_item_related_records.item_identifier = '/IGNORE' ^observation_item_related_records.item_type = '/IGNORE' ^observation_item_related_records.access_comment = '/IGNORE' -- END Modif phx -- Identify the Observation /assigning_identification( id=@id, id_class_name=@id_class_name, id_ecl_id=@id_ecl_id, org_id=@org_id, org_id_class_name=@org_id_class_name, org_id_ecl_id=@org_id_ecl_id, items=^observation)/ -- Assign a date to the Observation /assigning_time( date_class_name=@date_class_name, date_ecl_id=@date_ecl_id, year=@year, month=@month, day=@day, hour=@hour, minute=@minute, second=@second, sense=@sense, hour_offset=@hour_offset, minute_offset=@minute_offset, items=^observation)/ -- Assign a description to the Observation /assigning_descriptor( descr=@descr, class_name=@dsc_class_name, ecl_id=@dsc_ecl_id, is_assigned_to=^observation)/

Comment: (Rob Bodington 07-03-29)
The related related records are optional and represented by the Observation_item_selected As they are optional, the parameter related_records should be related_records(Type= 'ENTITY(Observation_item_selected)' ) and the Observation_item_selected, instantiated outside the template. The parameter applies_to should be: applies_to(Type= 'SELECT (observation_content_item)' ) as it is the Observation -- Mark the Identification_assignment entity as -- referable when this template is used by binding it to the reference -- parameter id_assgn %^observation = Observation% Observation.id = '/IGNORE' Observation.name = '/IGNORE' Observation.description = '/IGNORE' Observation.observed_during -> @observed_during Observation.observed_by -> @observed_by Observation.in_context -> @in_context Observation_item_selected %^observation_item = Observation_item_selected% Observation.applies_to -> ^observation_item ^observation_item_applies_to.contents -> @applies_to ^observation_item_applies_to.item_identifier = '/IGNORE' ^observation_item_applies_to.item_type = '/IGNORE' ^observation_item_applies_to.access_comment = '/IGNORE' -- Identify the Observation /assigning_identification( id=@id, id_class_name=@id_class_name, id_ecl_id=@id_ecl_id, org_id=@org_id, org_id_class_name=@org_id_class_name, org_id_ecl_id=@org_id_ecl_id, items=^observation)/ -- Assign a date to the Observation /assigning_time( date_class_name=@date_class_name, date_ecl_id=@date_ecl_id, year=@year, month=@month, day=@day, hour=@hour, minute=@minute, second=@second, sense=@sense, hour_offset=@hour_offset, minute_offset=@minute_offset,

Issue: RBN-2 by Rob Bodington (07-06-29) minor_technical issue
Resolution: Accept. Status: closed

Figure 1 An EXPRESS-G representation of the Information model for assigning_observation The diagram does not show the following parameters: observed_during observed_by in_context

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: RBN-3 by Rob Bodington (07-08-07) minor_technical issue
Resolution: Accept. Status: closed

The input parameter related_records is not used at all by the path of this template. It should be removed

Comment: (Rob Bodington 07-11-19)
Parameter is now used in the path

Issue: RBN-4 by Rob Bodington (07-11-18) minor_technical issue
Resolution: Accept. Status: closed

The date parameters have incorrect definitions: E.g. hour and minute

Comment: (Rob Bodington 07-11-18)
Corrected, and provided a better description

Issue: RBN-5 by Rob Bodington (07-11-18) minor_technical issue
Resolution: Accept. Status: closed

The parameters observed_during (Type= 'ENTITY (Activity_actual)' , Optional) observed_by (Type= 'SELECT (observation_recorder)' , Optional) in_context (Type= 'SELECT (observed_context)' , Optional) are not shown in the express-g diagram

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: RBN-6 by Rob Bodington (07-11-18) minor_technical issue
Resolution: Accept. Status: closed

related_records parameter is not instantiated in the path.

Comment: (Rob Bodington 07-11-19)
Added to path

Issue: RBN-7 by Rob Bodington (07-11-19) minor_technical issue
Resolution: Accept. Status: closed

The characterization section talk about work order not observation

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: RBN-8 by Rob Bodington (07-11-19) minor_technical issue
Resolution: Accept. Status: closed

The Observation_item is shown as an abstract supertype - it is not. The diagram should state that Observation_item should not be used. I.e. is in effect an abstract supertype. Furthermore, Observation_item_selected.contents is not an aggregate.

Comment: (Rob Bodington 07-11-19)
Corrected

Issue: DNV-18 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clauise: 22 major issues still open against capability

Comment: (Rob Bodington 08-02-15)
These do not affect the template

Issue: DNV-19 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clause: 28 #8 an #9 (grey areas) not needed for instantiation

Comment: (Rob Bodington 08-02-15)
Corrected

Issue: DNV-20 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clause: 52 ENUMERATION not a legal type acc. to the checklist

Comment: (Rob Bodington 08-02-15)
This is an error in the checklist

Issue: DNV-21 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clause: 54 Observation_item_selected not a legal type (AP239 issue RBN-7)

Comment: (Rob Bodington 08-02-15)
It has been added to the dexlib schema and a SEDS raised

Issue: DNV-22 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clause: 66 Observation_item_selected not described as a sub type of Observation item. Necessary?

Comment: (Rob Bodington 08-02-15)
This is an issue against the XSLT - it can not hyperlink to the express not in the schema

Issue: DNV-23 by Tore Hartvigsen, DNV (2008-1-22) minor_technical issue
Resolution: Accept. Status: closed

Issue file: template_issues_20080129.xls Template: Assigning_observation Check list clause: 73 :std used instead of :sample

Comment: (Rob Bodington 08-02-15)
This is allowable as PLCS ref data i being used

Issue: RBN-9 by Rob Bodington (08-02-15) minor_technical issue
Resolution: Accept. Status: closed

There should be a uniqueness constraint ensuring that the only one observation with a given id is used.

Comment: (Rob Bodington 08-02-15)
Added